Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the BLAS interface directly in the GemmKernels.jl module. #132

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jul 5, 2023

No description provided.

@maleadt
Copy link
Member Author

maleadt commented Jul 5, 2023

Benchmark results for commit ba08467 (comparing to f355b08):

ID mean₁ mean₂ Δmin
["BLAS", "WMMA", "Float16*Float16=Float32 (256×256×256, beta)"] 40.614 μs ± 480.822 ns 43.520 μs ± 518.942 ns -7.0% ❌

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 76.19% and project coverage change: -0.15 ⚠️

Comparison is base (92d26eb) 31.20% compared to head (ba08467) 31.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   31.20%   31.05%   -0.15%     
==========================================
  Files          11       10       -1     
  Lines         875      879       +4     
==========================================
  Hits          273      273              
- Misses        602      606       +4     
Impacted Files Coverage Δ
src/GemmKernels.jl 100.00% <ø> (ø)
src/matmul.jl 88.00% <76.19%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit 5a45fe3 into master Jul 5, 2023
@maleadt maleadt deleted the tb/toplevel branch July 5, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant